Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the existing zcl codec bits to match the data format of the new ones we are planning to add. #1645

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Change the existing zcl codec bits to match the data format of the new ones we are planning to add. #1645

merged 1 commit into from
Jul 21, 2020

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

The existing wire format for data model commands and the wire format we are using in #1609 are different

Summary of Changes

Change the existing format to match the new one.

fixes #1643

@bzbarsky-apple bzbarsky-apple self-assigned this Jul 17, 2020
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 324 324
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_loc,0,4456
.debug_info,0,2488
.debug_line,0,1042
.debug_ranges,0,496
.text,324,324
.symtab,0,80
.debug_abbrev,0,75
.debug_str,0,51
.debug_macro,0,18
.strtab,0,14
.debug_frame,0,-8
[Unmapped],0,-324

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .text 400 400
chip-standalone-demo.out .rodata 212 212
chip-standalone-demo.out .eh_frame 8 8
chip-standalone-demo.out [LOAD #4 [R]] -4 -4
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_info,0,819
.text,400,400
.debug_str,0,250
.rodata,212,212
.debug_line,0,161
.debug_abbrev,0,72
.debug_macro,0,67
.strtab,0,50
.symtab,0,48
.eh_frame,8,8
[LOAD #4 [R]],-4,-4
.debug_loc,0,-48
[Unmapped],0,-619

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 164 164
chip-wifi-echo.elf .flash.rodata 160 160
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,194
.flash.text,164,164
.flash.rodata,160,160
.debug_line,0,138
.debug_abbrev,0,47
.debug_str,0,22
.symtab,0,16
.strtab,0,14
[Unmapped],0,-159

@woody-apple
Copy link
Contributor

@andy31415 @BroderickCarlin @jelderton @saurabhst ?

bhaskar-apple
bhaskar-apple reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@bhaskar-apple bhaskar-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelderton
jelderton reviewed Jul 21, 2020
View reviewed changes
src/app/plugin/codec-simple/codec-simple.c
#include <memory.h>
#include <stdint.h>

#include "../../gen/gen-command-id.h"
Copy link

@jelderton jelderton Jul 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other places in the tree will symlink to this header so that code doesn't have to know the tree structure. perhaps something to consider as an enhancement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most things worked if I just used "gen/gen-command-id.h" here, but the "main build" did not. If there's a way to make that work, I'd love to know how.

@woody-apple woody-apple merged commit 4fa9a9f into project-chip:master Jul 21, 2020
@bzbarsky-apple bzbarsky-apple deleted the align-codecs branch July 21, 2020 21:09
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request Mar 18, 2024
@jmartinez-silabs
Pull request project-chip#1648: [Cherry-pick] Provision 2.0 with late…
eae4864 
…st fixes

Merge in WMN_TOOLS/matter from cherry-pick/provision_2.0 to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 087b18e961396a50fc769b38f2c2ee1009dab588
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:34:39 2024 +0000

    Pull request project-chip#1645: Bugfix: Provision: README typos.

    Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

    Squashed commit of the following:

    commit d09303c35e73e0068f07973b8933fb9e97d9ddee
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 11:38:01 2024 -0400

        Bugfix: Provision: README typos.

commit 5356620caa1140925915d07cdb17322629c12373
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:28:34 2024 +0000

    Merge pull request project-chip#1646 in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Auto-Merge: Pull request project-chip#1646: [AUTO] Bugfix: Provision: Backwards-compatible header moved to the temp folder.

    Merge in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 8e005e302ea19e280e8ad88f0dd3605450021b96
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 15:11:38 2024 -0400

        Bugfix: Provision: Backwards-compatible header moved to the temp folder.

commit 9a1927cd9c5d0d2e93e3093c8b91da91eac10eaf
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 19:01:30 2024 +0000

    Pull request project-chip#1643: Bugfix: Provision defaults.

    Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
    Author: Ricardo Casallas <[email protected]>
    Date:   Thu Mar 14 10:17:52 2024 -0400

        Bugfix: Provision defaults.

... and 1 more commit
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1645: Bugfix: Provision: README typos.
fdb117f 
Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

Squashed commit of the following:

commit d09303c35e73e0068f07973b8933fb9e97d9ddee
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 11:38:01 2024 -0400

    Bugfix: Provision: README typos.
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#1648: [Cherry-pick] Provision 2.0 with late…
d61d024 
…st fixes

Merge in WMN_TOOLS/matter from cherry-pick/provision_2.0 to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 087b18e961396a50fc769b38f2c2ee1009dab588
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:34:39 2024 +0000

    Pull request project-chip#1645: Bugfix: Provision: README typos.

    Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

    Squashed commit of the following:

    commit d09303c35e73e0068f07973b8933fb9e97d9ddee
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 11:38:01 2024 -0400

        Bugfix: Provision: README typos.

commit 5356620caa1140925915d07cdb17322629c12373
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:28:34 2024 +0000

    Merge pull request project-chip#1646 in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Auto-Merge: Pull request project-chip#1646: [AUTO] Bugfix: Provision: Backwards-compatible header moved to the temp folder.

    Merge in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 8e005e302ea19e280e8ad88f0dd3605450021b96
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 15:11:38 2024 -0400

        Bugfix: Provision: Backwards-compatible header moved to the temp folder.

commit 9a1927cd9c5d0d2e93e3093c8b91da91eac10eaf
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 19:01:30 2024 +0000

    Pull request project-chip#1643: Bugfix: Provision defaults.

    Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
    Author: Ricardo Casallas <[email protected]>
    Date:   Thu Mar 14 10:17:52 2024 -0400

        Bugfix: Provision defaults.

... and 1 more commit
rcasallas-silabs added a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1645: Bugfix: Provision: README typos.
47c989d 
Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

Squashed commit of the following:

commit d09303c35e73e0068f07973b8933fb9e97d9ddee
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 11:38:01 2024 -0400

    Bugfix: Provision: README typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelderton jelderton jelderton approved these changes

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@bhaskar-apple bhaskar-apple Awaiting requested review from bhaskar-apple

Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change chipZclProcessIncoming to use the same data format as the chip-zcl-zpro command encoder/decoder
5 participants
@bzbarsky-apple @woody-apple @saurabhst @bhaskar-apple @jelderton